FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.8

Threshold is Low

Effort is Default

Summary

Classes Bugs Errors Missing Classes
145 13 0 0

Files

Class Bugs
ch.busyboxes.agoo.controller.FolderController 1
ch.busyboxes.agoo.controller.model.WebWatchedFile 2
ch.busyboxes.agoo.dao.impl.FileSystemDAOImpl 1
ch.busyboxes.agoo.dao.impl.WatchedFileDAOImpl$1 1
ch.busyboxes.agoo.dao.impl.WatcherTaskDAOImpl$1 1
ch.busyboxes.agoo.model.WatchedFile 2
ch.busyboxes.agoo.model.WatcherTask 2
ch.busyboxes.agoo.service.impl.WatchedFolderServiceImpl 3

ch.busyboxes.agoo.controller.FolderController

Bug Category Details Line Priority
Dead store to folderAdditionForm in ch.busyboxes.agoo.controller.FolderController.addFolder(FolderAdditionForm, BindingResult, ModelMap) STYLE DLS_DEAD_LOCAL_STORE 78 High

ch.busyboxes.agoo.controller.model.WebWatchedFile

Bug Category Details Line Priority
ch.busyboxes.agoo.controller.model.WebWatchedFile.getLastCheck() may expose internal representation by returning WebWatchedFile.lastCheck MALICIOUS_CODE EI_EXPOSE_REP 84 Medium
ch.busyboxes.agoo.controller.model.WebWatchedFile.setLastCheck(Date) may expose internal representation by storing an externally mutable object into WebWatchedFile.lastCheck MALICIOUS_CODE EI_EXPOSE_REP2 93 Medium

ch.busyboxes.agoo.dao.impl.FileSystemDAOImpl

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in ch.busyboxes.agoo.dao.impl.FileSystemDAOImpl.computeMd5Hash(String) STYLE REC_CATCH_EXCEPTION 145 Low

ch.busyboxes.agoo.dao.impl.WatchedFileDAOImpl$1

Bug Category Details Line Priority
The class ch.busyboxes.agoo.dao.impl.WatchedFileDAOImpl$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 64-72 Low

ch.busyboxes.agoo.dao.impl.WatcherTaskDAOImpl$1

Bug Category Details Line Priority
The class ch.busyboxes.agoo.dao.impl.WatcherTaskDAOImpl$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 35-42 Low

ch.busyboxes.agoo.model.WatchedFile

Bug Category Details Line Priority
ch.busyboxes.agoo.model.WatchedFile.getLastCheck() may expose internal representation by returning WatchedFile.lastCheck MALICIOUS_CODE EI_EXPOSE_REP 105 Medium
ch.busyboxes.agoo.model.WatchedFile.setLastCheck(Date) may expose internal representation by storing an externally mutable object into WatchedFile.lastCheck MALICIOUS_CODE EI_EXPOSE_REP2 114 Medium

ch.busyboxes.agoo.model.WatcherTask

Bug Category Details Line Priority
ch.busyboxes.agoo.model.WatcherTask.getCreated() may expose internal representation by returning WatcherTask.created MALICIOUS_CODE EI_EXPOSE_REP 120 Medium
ch.busyboxes.agoo.model.WatcherTask.setCreated(Date) may expose internal representation by storing an externally mutable object into WatcherTask.created MALICIOUS_CODE EI_EXPOSE_REP2 129 Medium

ch.busyboxes.agoo.service.impl.WatchedFolderServiceImpl

Bug Category Details Line Priority
WatchedFolderServiceImpl.fileSystemDAO not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available Low
WatchedFolderServiceImpl.watchedFolderDAO not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available Low
WatchedFolderServiceImpl.watcherTaskService not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available Low